Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1264 fix custom time range + reset button #371

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

jpinsonneau
Copy link
Contributor

  • Make custom time range onChange compatible with any PF version
  • Add Reset button
  • Keeps values between custom / last X selections

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #371 (40ef5f5) into main (eafaa3b) will decrease coverage by 0.56%.
Report is 1 commits behind head on main.
The diff coverage is 58.97%.

@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
- Coverage   57.83%   57.28%   -0.56%     
==========================================
  Files         166      167       +1     
  Lines        7679     7751      +72     
  Branches      918      922       +4     
==========================================
- Hits         4441     4440       -1     
- Misses       2971     3044      +73     
  Partials      267      267              
Flag Coverage Δ
uitests 58.14% <58.97%> (-0.03%) ⬇️
unittests 54.91% <ø> (-1.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/components/modals/time-range-modal.tsx 47.70% <58.97%> (-1.37%) ⬇️

... and 1 file with indirect coverage changes

@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1fe04e7 into netobserv:main Aug 23, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants