NETOBSERV-967 skip ticks when popups are open

[jpinsonneau]

Auto refresh seems to retrigger the popups rendering and resets their content.

This PR simply skip tick when any popup is open to:

• avoid useless rendering
• keep perfs stable while in popups

[memodi]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:3b66276

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=3b66276 make set-plugin-image

[memodi]

this solves one issue where column is automatically unselected during auto-refresh, however, this is still giving problems when selecting group columns in cypress tests, I have this code: https://github.com/openshift/openshift-tests-private/blob/master/frontend/tests/netobserv/netflow_table.cy.ts#L134-L181 , I unskipped this test and uncommented lines after comment for 967 bug the test still gets page rendered where group selected columns does not exist.

here you can see the K8s-owner object column goes missing despite selected:

[codecov]

Codecov Report

Patch coverage: 57.14% and project coverage change: -0.32% ⚠️

Comparison is base (1fe04e7) 57.70% compared to head (75de06a) 57.38%.
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   57.70%   57.38%   -0.32%     
==========================================
  Files         166      167       +1     
  Lines        7710     7803      +93     
  Branches      932      941       +9     
==========================================
+ Hits         4449     4478      +29     
- Misses       2993     3056      +63     
- Partials      268      269       +1     

Flag	Coverage Δ
uitests	58.31% <57.14%> (+0.28%)	⬆️
unittests	54.82% <ø> (-1.96%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
web/src/components/netflow-traffic.tsx	55.83% <0.00%> (+0.05%)	⬆️
web/src/components/modals/columns-modal.tsx	72.72% <100.00%> (+0.41%)	⬆️
...eb/src/components/modals/overview-panels-modal.tsx	73.01% <100.00%> (+0.43%)	⬆️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jpinsonneau]

this solves one issue where column is automatically unselected during auto-refresh, however, this is still giving problems when selecting group columns in cypress tests, I have this code: https://github.com/openshift/openshift-tests-private/blob/master/frontend/tests/netobserv/netflow_table.cy.ts#L134-L181 , I unskipped this test and uncommented lines after comment for 967 bug the test still gets page rendered where group selected columns does not exist.

here you can see the K8s-owner object column goes missing despite selected:

Yes I remember we had that discussion but I'm still not able to reproduce using our cypress 🤔
I have added a similar method than your approach that uses checkboxes and it still works on my side
https://github.com/netobserv/network-observability-console-plugin/pull/375/files#diff-bbb920770f884a6314eb2ee333b15fd3cc85ad22e10ce7431b6d090e5fc9be76R112-R116

We are using cypress 12.5.1 whereas you are on 11.2.0. Could it be related ?

Also tried a page reload but still works 2b0ae80

[jpinsonneau]

Also added an extra check in the popup useEffect 1a878fa

Can you please let me know if it solve your issue @memodi ?

[memodi]

/ok-to-test

Can you please let me know if it solve your issue @memodi ?

Sure, I can try. I see you're checking for 4 columns, could you check in your add for #K8S_OwnerObject, then I reload() and check for [data-test=th-K8S_OwnerObject] > .pf-c-table__button existence where I face most challenges.

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:94dc4c1

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=94dc4c1 make set-plugin-image

[memodi]

Also added an extra check in the popup useEffect 1a878fa

@jpinsonneau I am seeing much better results with this commit, I ran test ~10 times where I also removed reload() and wait() in between and it passed all the times. Thank you!

/label qe-approved

[jotak]

is that an intentional change or something you forgot to switch back to original?

[jpinsonneau]

I mostly use standalone for these so I guess it would be great to keep it as default

[jotak]

LGTM with a small question

[openshift-ci]

New changes are detected. LGTM label has been removed.

[jpinsonneau]

I had to add a case to fix testing since useEffect are not correctly managed by enzyme
75de06a

In the end it allows columns to be updated at first start independently of the popup state (open / closed).

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment