-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-967 skip ticks when popups are open #375
Conversation
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=3b66276 make set-plugin-image |
this solves one issue where column is automatically unselected during auto-refresh, however, this is still giving problems when selecting group columns in cypress tests, I have this code: https://github.com/openshift/openshift-tests-private/blob/master/frontend/tests/netobserv/netflow_table.cy.ts#L134-L181 , I unskipped this test and uncommented lines after comment for 967 bug the test still gets page rendered where group selected columns does not exist. here you can see the K8s-owner object column goes missing despite selected: |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
==========================================
- Coverage 57.70% 57.38% -0.32%
==========================================
Files 166 167 +1
Lines 7710 7803 +93
Branches 932 941 +9
==========================================
+ Hits 4449 4478 +29
- Misses 2993 3056 +63
- Partials 268 269 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Yes I remember we had that discussion but I'm still not able to reproduce using our cypress 🤔 We are using cypress Also tried a page reload but still works 2b0ae80 |
/ok-to-test
Sure, I can try. I see you're checking for 4 columns, could you check in your add for |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=94dc4c1 make set-plugin-image |
@jpinsonneau I am seeing much better results with this commit, I ran test ~10 times where I also removed /label qe-approved |
export const url = 'http://localhost:9000/netflow-traffic'; | ||
// export const url = 'http://localhost:9001'; | ||
// export const url = 'http://localhost:9000/netflow-traffic'; | ||
export const url = 'http://localhost:9001'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that an intentional change or something you forgot to switch back to original?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly use standalone
for these so I guess it would be great to keep it as default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a small question
New changes are detected. LGTM label has been removed. |
I had to add a case to fix testing since In the end it allows columns to be updated at first start independently of the popup state (open / closed). |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Auto refresh seems to retrigger the popups rendering and resets their content.
This PR simply skip
tick
when any popup is open to: