-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1242 Console plugin build infos #376
Conversation
jpinsonneau
commented
Aug 28, 2023
•
edited
Loading
edited
- get build version and build date from backend
- display these
- in query summary
- in console as debug
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
==========================================
- Coverage 57.67% 57.15% -0.52%
==========================================
Files 166 167 +1
Lines 7712 7789 +77
Branches 935 935
==========================================
+ Hits 4448 4452 +4
- Misses 2993 3066 +73
Partials 271 271
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Would it be ok as well to just write that with (edit: actually just seeing you also write it via |
I can add an extra section like |
how would the Version show for downstream builds? would it show the iteration for.e.g: 1.4.0-27 ? I am fine having it a way that you have under Configuration. Thanks! |
Yes ! That's my expectation. It reuses the tags from the makefile; these are already displayed in pod logs |
Yes +1 for an extra section like "Version" |
New changes are detected. LGTM label has been removed. |
Done: |
LGTM, I can verify this post-merge on downstream builds. |
/label qe-approved |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks guys ! |