NETOBSERV-1275: Introduce new "INNER" direction for inner-node traffic #378
Conversation
jotak
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=5ea6d76 make set-plugin-image |
jotak
changed the title
|
@jotak: This pull request references NETOBSERV-1275 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
In Traffic Flows views, new kind of Direction: Inner for on-node traffic:
The "Total bytes" metric on topology (edge labels) now matches the actual bytes count as reported in the Traffic Flows view:
|
github-actions
bot
removed
the
ok-to-test
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 57.94% 57.17% -0.77%
==========================================
Files 166 167 +1
Lines 7725 7885 +160
Branches 938 959 +21
==========================================
+ Hits 4476 4508 +32
- Misses 2981 3101 +120
- Partials 268 276 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
There was a problem hiding this comment.
Approach seems good, thanks @jotak
Have you tried with conversation tracking ? It would be great to solve all at once. See netobserv/flowlogs-pipeline#483 (review)
| ( | ||
| recs.find( | ||
| r => | ||
| r.fields.DnsId !== undefined || r.fields.PktDropBytes !== undefined || r.fields.PktDropPackets !== undefined |
There was a problem hiding this comment.
| r.fields.DnsId !== undefined || r.fields.PktDropBytes !== undefined || r.fields.PktDropPackets !== undefined | |
| r.fields.DnsId !== undefined || r.fields.PktDropPackets !== undefined |
I rely on PktDropPackets for this check. Same on FLP side.
There was a problem hiding this comment.
Also need to change the Duplicated flows tooltip if you do that change:
Currently:
A flow might be reported from several interfaces, and from both source and destination nodes, making it appear several times.
By default, duplicates are hidden in favor of Ingress traffic. Showing duplicates is not possible in Overview and Topology tabs to avoid altering metric calculations.
Use Direction filter to switch between Ingress / Egress traffic.
There was a problem hiding this comment.
Also in the Direction column tooltip, we should probably clarify that it's direction related to the node
There was a problem hiding this comment.
yes, I was even thinking about changing the column name to make it more explicit.
Should we also expose IfDirection as filter / column ?
There was a problem hiding this comment.
+1, I created a follow-up: https://issues.redhat.com/browse/NETOBSERV-1280
Related PR: netobserv/flowlogs-pipeline#483 The flows (and duplicates) generated for inner-node traffic differs compared to node-to-node traffic, and reinterpret direction isn't able to decide between ingress or egress. This is causing discrepancies with the dedup mechanism that filters out flows where Duplicate=true and also favors ingress over egress, since the Duplicate flag can be set randomly on ingress or on egress. To fix that, the proposed solution is to create this new INNER direction specifically for this kind of traffic. Deduping this INNER traffic can then rely solely on the Duplicate flag, since that flag was set from a single Agent (single node) there will always be only one Duplicate=false.
|
thanks @jpinsonneau |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related PR: netobserv/flowlogs-pipeline#483
The flows (and duplicates) generated for inner-node traffic differs compared to node-to-node traffic, and reinterpret direction isn't able to decide between ingress or egress. This is causing discrepancies with the dedup mechanism that filters out flows where Duplicate=true and also favors ingress over egress, since the Duplicate flag can be set randomly on ingress or on egress.
To fix that, the proposed solution is to create this new INNER direction specifically for this kind of traffic. Deduping this INNER traffic can then rely solely on the Duplicate flag, since that flag was set from a single Agent (single node) there will always be only one Duplicate=false.