Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1113 fix pktDrop & FlowRTT merge #381

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

jpinsonneau
Copy link
Contributor

It seems I had issues during rebase. This PR fix PktDrop & RTT flags checks.

@jpinsonneau jpinsonneau added the no-qe This PR doesn't necessitate QE approval label Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.54% ⚠️

Comparison is base (84e175b) 57.59% compared to head (713e8ea) 57.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
- Coverage   57.59%   57.05%   -0.54%     
==========================================
  Files         166      167       +1     
  Lines        7812     7885      +73     
  Branches      961      961              
==========================================
  Hits         4499     4499              
- Misses       3034     3107      +73     
  Partials      279      279              
Flag Coverage Δ
uitests 57.97% <100.00%> (ø)
unittests 54.51% <ø> (-1.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/components/netflow-traffic.tsx 55.28% <ø> (ø)
web/src/utils/filter-definitions.ts 66.66% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpinsonneau
Copy link
Contributor Author

Thanks guys !

@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e53bf2e into netobserv:main Sep 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants