Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ovs_drop_last_action doc #382

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

msherif1234
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -3.09% ⚠️

Comparison is base (84e175b) 57.59% compared to head (1e6bd99) 54.51%.

❗ Current head 1e6bd99 differs from pull request most recent head a930226. Consider uploading reports for the commit a930226 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
- Coverage   57.59%   54.51%   -3.09%     
==========================================
  Files         166       30     -136     
  Lines        7812     2095    -5717     
  Branches      961        0     -961     
==========================================
- Hits         4499     1142    -3357     
+ Misses       3034      837    -2197     
+ Partials      279      116     -163     
Flag Coverage Δ
uitests ?
unittests 54.51% <ø> (-1.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 138 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @msherif1234.
Just noticed these are not translated. That's not a problem for now since we only support english but we should add i18n in these descriptions later 😄

@openshift-ci openshift-ci bot added the lgtm label Sep 7, 2023
@msherif1234 msherif1234 added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Sep 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2ec3c5d into netobserv:main Sep 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants