Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1299 missing DNS latency in topology & NETOBSERV-1294 RTT based panels seen by default #384

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Sep 12, 2023

NETOBSERV-1299 missing DNS latency in topology:
While writing the blogs article I saw that RTT was added to topology view but I never came back to DNS to make it also available.

image

This story enable it using the same approach as RTT: only average is available and Max / P90 / P99 will be introduced by https://issues.redhat.com/browse/NETOBSERV-1227 


NETOBSERV-1294 RTT based panels seen by default:
Also took the opportunity to fix this in the same PR since the same code is affected.


It would be cool to be able to backport these to 1.4 as it's small changes: #388

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 86.48% and project coverage change: -0.42% ⚠️

Comparison is base (bffb860) 57.69% compared to head (1ea79f8) 57.27%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   57.69%   57.27%   -0.42%     
==========================================
  Files         166      168       +2     
  Lines        7817     7944     +127     
  Branches      962      970       +8     
==========================================
+ Hits         4510     4550      +40     
- Misses       3030     3115      +85     
- Partials      277      279       +2     
Flag Coverage Δ
uitests 58.16% <86.48%> (+0.14%) ⬆️
unittests 54.79% <ø> (-1.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../components/dropdowns/metric-function-dropdown.tsx 95.83% <0.00%> (ø)
...components/dropdowns/topology-display-dropdown.tsx 47.36% <ø> (ø)
web/src/components/metrics/metrics-content.tsx 86.20% <0.00%> (ø)
web/src/model/filters.ts 78.46% <ø> (ø)
web/src/utils/filter-definitions.ts 66.66% <ø> (ø)
.../src/components/dropdowns/metric-type-dropdown.tsx 70.96% <60.00%> (-16.54%) ⬇️
web/src/components/netflow-traffic.tsx 55.32% <76.92%> (+0.04%) ⬆️
web/src/utils/back-and-forth.ts 94.73% <94.73%> (ø)
web/src/utils/metrics.ts 88.16% <94.87%> (+1.80%) ⬆️
...ponents/netflow-topology/element-panel-metrics.tsx 86.48% <100.00%> (ø)
... and 2 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpinsonneau jpinsonneau changed the title NETOBSERV-1299 missing DNS latency in topology NETOBSERV-1299 missing DNS latency in topology & NETOBSERV-1294 RTT based panels seen by default Sep 12, 2023
Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Amoghrd
Copy link
Contributor

Amoghrd commented Sep 13, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 13, 2023
@github-actions
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:7ca3e15

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=7ca3e15 make set-plugin-image

@Amoghrd
Copy link
Contributor

Amoghrd commented Sep 13, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Sep 13, 2023
@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4c974a5 into netobserv:main Sep 14, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants