Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1222: create PR template #387

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Sep 13, 2023

No description provided.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 13, 2023

@jotak: This pull request references NETOBSERV-1222 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 93.25% and project coverage change: -0.37% ⚠️

Comparison is base (bffb860) 57.69% compared to head (545ec55) 57.33%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
- Coverage   57.69%   57.33%   -0.37%     
==========================================
  Files         166      168       +2     
  Lines        7817     7936     +119     
  Branches      962      968       +6     
==========================================
+ Hits         4510     4550      +40     
- Misses       3030     3107      +77     
- Partials      277      279       +2     
Flag Coverage Δ
uitests 58.24% <93.25%> (+0.22%) ⬆️
unittests 54.79% <ø> (-1.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/model/filters.ts 78.46% <ø> (ø)
web/src/utils/filter-definitions.ts 66.66% <ø> (ø)
web/src/components/netflow-traffic.tsx 55.24% <80.00%> (-0.04%) ⬇️
web/src/utils/back-and-forth.ts 94.73% <94.73%> (ø)
web/src/utils/metrics.ts 88.16% <94.87%> (+1.80%) ⬆️
web/src/model/flow-query.ts 87.50% <100.00%> (-10.07%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as first version !
Some ideas I have in mind for improvments:

  • Guided tour / Tooltips help required
  • Is feature gated / Automatically updated from config
  • Screenshots attachement

@jotak
Copy link
Member Author

jotak commented Sep 13, 2023

@jpinsonneau I'll merge for now but can you elaborate on that? What do you mean by "guided tour" for instance? Screenshot attachment => you mean adding a new item to the checklist asking to attact screenshots when relevant?

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@memodi
Copy link
Contributor

memodi commented Sep 13, 2023

Some ideas I have in mind for improvments:

  • Guided tour / Tooltips help required
  • Is feature gated / Automatically updated from config
  • Screenshots attachement

+1 on this for plugin these would be very helpful.

@openshift-merge-robot openshift-merge-robot merged commit b1e28d7 into netobserv:main Sep 13, 2023
9 checks passed
@jpinsonneau
Copy link
Contributor

jpinsonneau commented Sep 13, 2023

  • Guided tour / Tooltips help required

I usually forget to add guided tour while adding new features. Sometimes just some tooltips are good enough.
We should be able to mark PRs for that

  • Is feature gated / Automatically updated from config

That's useful for enablement. If something need to be hidden, such as 3D view, we need to provide the feature flag.
If it's automated it requires an operator PR

  • Screenshots attachement

Most of the time screens are better than words ☺️ but also super useful to come back on previous work and pick items to put in presentations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants