-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1222: create PR template #387
Conversation
@jotak: This pull request references NETOBSERV-1222 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
==========================================
- Coverage 57.69% 57.33% -0.37%
==========================================
Files 166 168 +2
Lines 7817 7936 +119
Branches 962 968 +6
==========================================
+ Hits 4510 4550 +40
- Misses 3030 3107 +77
- Partials 277 279 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as first version !
Some ideas I have in mind for improvments:
- Guided tour / Tooltips help required
- Is feature gated / Automatically updated from config
- Screenshots attachement
@jpinsonneau I'll merge for now but can you elaborate on that? What do you mean by "guided tour" for instance? Screenshot attachment => you mean adding a new item to the checklist asking to attact screenshots when relevant? /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
+1 on this for plugin these would be very helpful. |
I usually forget to add guided tour while adding new features. Sometimes just some tooltips are good enough.
That's useful for enablement. If something need to be hidden, such as 3D view, we need to provide the feature flag.
Most of the time screens are better than words |
No description provided.