NETOBSERV-1337 DSCP filter & side panel details

[jpinsonneau]

Description

Add DSCP

• Filter
• Side panel details in Protocol field as same as ICMP.
  We can rename / move if necessary.

A followup will contains the following changes:

• Graph requires NETOBSERV-1185 Console plugin async overview metrics #389
• Table column (not sure it's needed here)
• Quick filter dropdown

Dependencies

netobserv/netobserv-ebpf-agent#158
netobserv/flowlogs-pipeline#503

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[codecov]

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (62bdb9d) 56.69% compared to head (e0059b1) 57.20%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
+ Coverage   56.69%   57.20%   +0.51%     
==========================================
  Files          29      169     +140     
  Lines        2025     7990    +5965     
  Branches        0      977     +977     
==========================================
+ Hits         1148     4571    +3423     
- Misses        761     3140    +2379     
- Partials      116      279     +163     

Flag	Coverage Δ
uitests	58.09% <12.00%> (?)
unittests	54.71% <100.00%> (-1.98%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
pkg/model/fields/fields.go	100.00% <100.00%> (ø)
web/src/api/ipfix.ts	100.00% <ø> (ø)
web/src/model/filters.ts	78.46% <ø> (ø)
web/src/utils/filter-definitions.ts	66.66% <ø> (ø)
web/src/components/netflow-record/record-field.tsx	64.56% <15.78%> (ø)
web/src/utils/dscp.ts	9.67% <9.67%> (ø)

... and 135 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:055d42e

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=055d42e make set-plugin-image

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:3b262b1

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=3b262b1 make set-plugin-image

[Amoghrd]

@jpinsonneau The branch still shows out-of-date with master, should it be rebased with master to get the duplicate field added to labels change or is it fine?

[jpinsonneau]

@jpinsonneau The branch still shows out-of-date with master, should it be rebased with master to get the duplicate field added to labels change or is it fine?

It's the async overview; it's not related you can go ahead with the current version 😉

[Amoghrd]

@jpinsonneau Question regarding the DSCP value filter. Even though there is DSCP related info present under Protocol section in the side panel, there is no filter button present, is this deliberate? I am asking since all other filters have a filter button too next to them in the side panel

[jpinsonneau]

@jpinsonneau Question regarding the DSCP value filter. Even though there is DSCP related info present under Protocol section in the side panel, there is no filter button present, is this deliberate? I am asking since all other filters have a filter button too next to them in the side panel

You should have filter button next to "Protocol" field but indeed it filter on protocol and not on DSCP.
I'll add a dropdown in the same style as topology ones that allows to select multiple options (Source / Dest)

[Amoghrd]

@jpinsonneau The above dropdown style for DSCP will be implemented in this PR or a later PR?

[jpinsonneau]

@jpinsonneau The above dropdown style for DSCP will be implemented in this PR or a later PR?

As you prefer 😸 what is the easiest for you ?

• If you want to test all at one I can add both graphs and dropdown in the same PR.
• If you already tested this and wait for me we can just merge as is and I'll open a followup

[Amoghrd]

/label qe-approved

[jpinsonneau]

Created a followup for graphs & dropdown:
https://issues.redhat.com/browse/NETOBSERV-1353

[msherif1234]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jpinsonneau]

Thanks @Amoghrd @msherif1234 !