-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1319 single graph focus #405
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
==========================================
- Coverage 58.09% 57.56% -0.53%
==========================================
Files 169 170 +1
Lines 7985 8128 +143
Branches 990 999 +9
==========================================
+ Hits 4639 4679 +40
- Misses 3067 3170 +103
Partials 279 279
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5bc50ba
to
27a3fb8
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=4710166 make set-plugin-image |
Rebased with no changes |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=00d68f4 make set-plugin-image |
Rebased with no changes |
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=af20c63 make set-plugin-image |
As requested in https://issues.redhat.com/browse/NETOBSERV-1319 comments, I've added a tooltip: c58c40a |
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=2585361 make set-plugin-image |
/label qe-approved |
I'm seeing small glitches when testing:
I'm good to merge if you prefer and we add that to a new bug ticket ; because otherwise, LGTM /lgtm |
I can't reproduce locally, however I pushed a commit to ensure the flex div doesn't wrap content
That's on all browers. I can suggest to switch focused panel on left and list on right as an easy fix 😸 WDYT ? |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=d91d01a make set-plugin-image |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=7d21e2f make set-plugin-image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Focus on a single graph for better display:
Screencast.from.2023-10-06.16-56-35.webm
Dependencies
Based on #389Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.