-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1316 & NETOBSERV-1380 - Get dns noError codes to always show graphs #422
Conversation
@Amoghrd I was not able to reproduce the Please let me know if you still see some issues. Thanks ! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
==========================================
- Coverage 57.92% 57.42% -0.50%
==========================================
Files 169 170 +1
Lines 7947 8015 +68
Branches 975 978 +3
==========================================
Hits 4603 4603
- Misses 3070 3139 +69
+ Partials 274 273 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Also added DNS Latency & Response Code columns as default here and in the impacted PRs: |
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=ef75123 make set-plugin-image |
/label qe-approved |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR remove the filter on
NoError
DNS codes on backend side to always return metrics. The filter is done on display side according to the selected options.It also enable
Show NoError
kebab options by default to avoid having empty graphs at first display.Finally,
NaN
are skipped in stats generation.Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.