NETOBSERV-1353 Console plugin feedback

[jpinsonneau]

Description

DSCP, ICMP Type, ICMP Code

• as separate columns
• as separate filters

Since ICMP values overlap between IPV4 / V6 and Types, I decided to not suggest dropdown options for theses.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[codecov]

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (78220a8) 57.95% compared to head (7d8153b) 57.61%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   57.95%   57.61%   -0.35%     
==========================================
  Files         169      170       +1     
  Lines        7942     8031      +89     
  Branches      978      986       +8     
==========================================
+ Hits         4603     4627      +24     
- Misses       3066     3126      +60     
- Partials      273      278       +5     

Flag	Coverage Δ
uitests	58.60% <45.71%> (+0.24%)	⬆️
unittests	54.79% <ø> (-1.98%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
web/src/components/__tests-data__/flows.ts	100.00% <ø> (ø)
web/src/model/filters.ts	78.46% <ø> (ø)
web/src/utils/filter-definitions.ts	66.66% <ø> (ø)
web/src/utils/protocol.ts	80.00% <100.00%> (+5.00%)	⬆️
web/src/utils/dscp.ts	66.66% <66.66%> (+56.98%)	⬆️
web/src/utils/filter-options.ts	51.16% <40.00%> (-0.69%)	⬇️
web/src/utils/icmp.ts	57.40% <25.00%> (-0.29%)	⬇️
web/src/components/netflow-record/record-panel.tsx	64.21% <50.00%> (-2.09%)	⬇️
web/src/utils/columns.ts	66.29% <66.66%> (-0.25%)	⬇️
web/src/components/netflow-record/record-field.tsx	64.28% <33.33%> (-0.29%)	⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[OlivierCazade]

LGTM, thanks!

[openshift-ci]

New changes are detected. LGTM label has been removed.

[jpinsonneau]

Fixed tests: 100b6a9

FYI side panel will not show n/a fields anymore as we are starting to have too many fields. Each field will show up as soon as a relevent value is available.

[Amoghrd]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:01d8fb3

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=01d8fb3 make set-plugin-image

[jpinsonneau]

Following @Amoghrd feedback, the ICMP type & code will show in red when protocol is not ICMP

[Amoghrd]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:f43e9d7

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=f43e9d7 make set-plugin-image

[Amoghrd]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:9a4283b

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=9a4283b make set-plugin-image

[Amoghrd]

/label qe-approved

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment