NETOBSERV-267 Panels & columns popup filters

[jpinsonneau]

Description

Add view filters to quickly pick panels / columns:

Dependencies

Panel ids are updated in #412

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[codecov]

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (f71c56d) 58.32% compared to head (d63c3b0) 58.28%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
web/src/components/modals/columns-modal.tsx	67.74%	10 Missing ⚠️
...eb/src/components/modals/overview-panels-modal.tsx	62.96%	9 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   58.32%   58.28%   -0.04%     
==========================================
  Files         167      167              
  Lines        8430     8463      +33     
  Branches     1077     1086       +9     
==========================================
+ Hits         4917     4933      +16     
- Misses       3201     3217      +16     
- Partials      312      313       +1     

Flag	Coverage Δ
uitests	59.01% <65.51%> (-0.06%)	⬇️
unittests	56.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:b940e0e

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=b940e0e make set-plugin-image

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:430ec4d

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=430ec4d make set-plugin-image

[jotak]

I have a few remarks but I'm fine if you want to address them in a follow-up:

• the clickable area on the chip filters is narrowed to just the text, instead of the whole button. It makes it sometimes difficult to clic
  

• some of the chips show no result when they're related to disabled features, like DNS or Drops

Otherwise, code lgtm!

[jpinsonneau]

I have a few remarks but I'm fine if you want to address them in a follow-up:

• the clickable area on the chip filters is narrowed to just the text, instead of the whole button. It makes it sometimes difficult to clic
  
• some of the chips show no result when they're related to disabled features, like DNS or Drops

Otherwise, code lgtm!

Thanks for testing, I'll take the necessary time to improve before merging 👍

[jpinsonneau]

@jotak I rebased and took the opportunity to improve from your feedback:

• the entire chip is now clickable
• the chips not matching to any column are not showing

Let me know if that works for you ! Thanks

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:597fb6d

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=597fb6d make set-plugin-image

[jotak]

/lgtm
thanks!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment