Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1400 Feature filters are observed even though they are not enabled #427

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Nov 9, 2023

Description

  • allow mapping on 0
  • added functions for duration / latency
  • updated sample config
  • improved column parsing

Dependencies

netobserv/network-observability-operator#488

Operator PR:

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 184 lines in your changes are missing coverage. Please review.

Comparison is base (6d73e0a) 58.09% compared to head (62ee2d9) 57.43%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
- Coverage   58.09%   57.43%   -0.66%     
==========================================
  Files         169      170       +1     
  Lines        7985     8080      +95     
  Branches      990      984       -6     
==========================================
+ Hits         4639     4641       +2     
- Misses       3067     3163      +96     
+ Partials      279      276       -3     
Flag Coverage Δ
uitests 58.58% <66.35%> (-0.03%) ⬇️
unittests 54.27% <31.53%> (-2.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/server/routes.go 89.65% <100.00%> (ø)
pkg/server/server.go 70.00% <100.00%> (ø)
web/src/api/ipfix.ts 100.00% <100.00%> (ø)
web/src/components/__tests-data__/columns.ts 100.00% <100.00%> (ø)
web/src/components/__tests-data__/config.ts 100.00% <100.00%> (ø)
web/src/components/__tests-data__/filters.ts 100.00% <100.00%> (ø)
web/src/components/__tests-data__/flows.ts 100.00% <100.00%> (ø)
web/src/components/filters/compare-filter.tsx 87.80% <100.00%> (-0.30%) ⬇️
web/src/components/filters/filters-dropdown.tsx 95.45% <100.00%> (ø)
web/src/components/filters/filters-helper.ts 100.00% <100.00%> (ø)
... and 27 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Amoghrd
Copy link
Contributor

Amoghrd commented Nov 9, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 9, 2023
Copy link

github-actions bot commented Nov 9, 2023

New image:
quay.io/netobserv/network-observability-console-plugin:183e73d

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=183e73d make set-plugin-image

@Amoghrd
Copy link
Contributor

Amoghrd commented Nov 9, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Nov 9, 2023
Copy link
Collaborator

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6f38318 into netobserv:main Nov 10, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants