NETOBSERV-1285 Move "query is slow" info to query summary #438
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #438 +/- ##
==========================================
+ Coverage 58.60% 58.67% +0.06%
==========================================
Files 167 167
Lines 8310 8314 +4
Branches 1061 1062 +1
==========================================
+ Hits 4870 4878 +8
+ Misses 3132 3126 -6
- Partials 308 310 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jotak
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=b93007b make set-plugin-image |
github-actions
bot
removed
the
ok-to-test
|
Rebased without changes |
jotak
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=64e7408 make set-plugin-image |
| {dateText} | ||
| {detailed && numQueries && ` ${t('running')} ${numQueries} ${numQueries > 1 ? t('queries') : t('query')}`} | ||
| {detailed && lastDuration && lastDuration > 0 && ` ${t('in')} ${formatDuration(lastDuration)}`} |
There was a problem hiding this comment.
not sure exactly what's wrong here, but often I end up seeing truncated text:
There was a problem hiding this comment.
that one should do the trick
6449195
There was a problem hiding this comment.
I was just looking at formatDuration ... in fact if we use formatDurationAboveMillisecond instead we cover more durations, as formatDuration ignores when it's below 1 second and the other is more precise
There was a problem hiding this comment.
@jpinsonneau I've marked lgtm but still I think it would be better to use formatDurationAboveMillisecond, don't you think?
There was a problem hiding this comment.
sure, done in 2e9e9cc
Thanks !
| lastRefresh={lastRefresh} | ||
| lastDuration={lastDuration} | ||
| warningMessage={warningMessage} | ||
| slownessReason={slownessReason()} |
There was a problem hiding this comment.
Something else I don't explain just looking at the code: for some reason I see the slowness message working for metrics query summary but not for flow query summary. You can see here, query took 9s but no warning:
There was a problem hiding this comment.
Ok, I think there is a totally different issue, probably not due to this PR, that is preventing the Promise.race call to work as expected when the flows table is displayed. In fact, when flow table is loading, the whole UI seems barely usable, like frozen. For instance, I can't open the query options or filters while it's fetching data. In topology or overview I don't have this problem, the UI is reactive. I have the feeling something is taking all compute time and doesn't give a chance to the setTimeout promise used in race to run properly. I can reproduce that problem both in chrome and firefox.
As soon as it finishes loading data, the UI retrieves its reactivity.
There was a problem hiding this comment.
Do you have all columns displayed ? That's typically something related to view drawing performances
There was a problem hiding this comment.
Table is having an issue rendering all rows. I have fixed it in b7a0939
There was a problem hiding this comment.
yep that sounds to have fix it! thanks
github-actions
bot
removed
the
ok-to-test
jotak
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=b0ab67b make set-plugin-image |
|
/lgtm |
github-actions
bot
removed
the
ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Move "query is slow" info to query summary
Dependencies
#412
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.