-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1435 Duplicate Id fields in Query Summary panel when PacketDrop enabled #441
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
==========================================
- Coverage 58.60% 57.84% -0.76%
==========================================
Files 167 168 +1
Lines 8305 8414 +109
Branches 1060 1063 +3
==========================================
Hits 4867 4867
- Misses 3126 3234 +108
- Partials 312 313 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@jpinsonneau In the code I see only bpsCount renamed to bytesPerSecondsCount; dont see any changes related to droppedCounts, was that missed? |
There is a switch case on the metrics query summary as following:
The flow one is not affected here but I renamed |
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=d78c780 make set-plugin-image |
/lgtm |
/label qe-approved |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Renammed
bytes
/packets
counter ids as follow:Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.