-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1443 Console plugin loki timeout should be configurable #446
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
- Coverage 58.55% 58.53% -0.02%
==========================================
Files 167 167
Lines 8310 8314 +4
Branches 1061 1061
==========================================
+ Hits 4866 4867 +1
- Misses 3135 3137 +2
- Partials 309 310 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=4772407 make set-plugin-image |
Since the queries could take more time than the selected refresh interval (up to 5 minutes), we should improve the This is a corner case so we can merge as is but I'm looking for ways to do that in parallel. |
/ok-to-test |
@jpinsonneau Could you rebase and remove the older ok-to-test label so that I can create a newer image for testing. TIA! |
New changes are detected. LGTM label has been removed. |
Updated branch and restored labels, the image is coming @Amoghrd ! |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=3465b95 make set-plugin-image |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR increase server write timeout if Loki one goes over.
Dependencies
netobserv/network-observability-operator#522
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.