Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1443 Console plugin loki timeout should be configurable #446

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

jpinsonneau
Copy link
Contributor

Description

This PR increase server write timeout if Loki one goes over.

Dependencies

netobserv/network-observability-operator#522

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6a3207b) 58.55% compared to head (2d3cdf6) 58.53%.
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/server/server.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
- Coverage   58.55%   58.53%   -0.02%     
==========================================
  Files         167      167              
  Lines        8310     8314       +4     
  Branches     1061     1061              
==========================================
+ Hits         4866     4867       +1     
- Misses       3135     3137       +2     
- Partials      309      310       +1     
Flag Coverage Δ
uitests 59.15% <ø> (ø)
unittests 56.75% <40.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 2, 2024
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 2, 2024
@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 2, 2024
@netobserv netobserv deleted a comment from github-actions bot Jan 2, 2024
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 2, 2024
@netobserv netobserv deleted a comment from github-actions bot Jan 2, 2024
@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 2, 2024
@netobserv netobserv deleted a comment from github-actions bot Jan 2, 2024
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 2, 2024
@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 2, 2024
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 2, 2024
@netobserv netobserv deleted a comment from github-actions bot Jan 2, 2024
@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 2, 2024
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 2, 2024
@netobserv netobserv deleted a comment from github-actions bot Jan 2, 2024
@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 2, 2024
Copy link

github-actions bot commented Jan 2, 2024

New image:
quay.io/netobserv/network-observability-console-plugin:4772407

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=4772407 make set-plugin-image

@jpinsonneau
Copy link
Contributor Author

Since the queries could take more time than the selected refresh interval (up to 5 minutes), we should improve the tick mechanism to postpone next call right after the results being returned.

This is a corner case so we can merge as is but I'm looking for ways to do that in parallel.

@Amoghrd
Copy link
Contributor

Amoghrd commented Jan 11, 2024

/ok-to-test

@Amoghrd
Copy link
Contributor

Amoghrd commented Jan 25, 2024

@jpinsonneau Could you rebase and remove the older ok-to-test label so that I can create a newer image for testing. TIA!

@openshift-ci openshift-ci bot removed the lgtm label Jan 25, 2024
Copy link

openshift-ci bot commented Jan 25, 2024

New changes are detected. LGTM label has been removed.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 25, 2024
@jpinsonneau jpinsonneau added lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. labels Jan 25, 2024
@jpinsonneau
Copy link
Contributor Author

Updated branch and restored labels, the image is coming @Amoghrd !

Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:3465b95

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=3465b95 make set-plugin-image

Copy link

openshift-ci bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0fdc43c into netobserv:main Jan 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants