Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TCP flags doc #449

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

jotak
Copy link
Member

@jotak jotak commented Jan 8, 2024

Give more details about what the TCP flags field means

Note, I'm flagging "no-doc" as there will be a doc review later anyway, with re-generated json reference

@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Jan 8, 2024
@jotak jotak requested a review from msherif1234 January 8, 2024 13:30
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (267780e) 58.61% compared to head (93060bb) 57.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
- Coverage   58.61%   57.90%   -0.72%     
==========================================
  Files         167      168       +1     
  Lines        8312     8414     +102     
  Branches     1061     1061              
==========================================
  Hits         4872     4872              
- Misses       3132     3234     +102     
  Partials      308      308              
Flag Coverage Δ
uitests 59.23% <ø> (ø)
unittests 54.22% <ø> (-2.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msherif1234
Copy link
Contributor

/LGTM

@jotak
Copy link
Member Author

jotak commented Jan 8, 2024

/approve

Copy link

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit bd8a90b into netobserv:main Jan 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants