Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1450: use isolated states for mobx #450

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Jan 9, 2024

Description

As mobx is also used by the console itself, it must be configured as isolated to prevent conflicting versions.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 9, 2024

@jotak: This pull request references NETOBSERV-1450 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Description

As mobx is also used by the console itself, it must be configured as isolated to prevent conflicting versions.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd8a90b) 58.61% compared to head (bef0a82) 57.90%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
- Coverage   58.61%   57.90%   -0.72%     
==========================================
  Files         167      168       +1     
  Lines        8312     8414     +102     
  Branches     1061     1061              
==========================================
  Hits         4872     4872              
- Misses       3132     3234     +102     
  Partials      308      308              
Flag Coverage Δ
uitests 59.23% <ø> (ø)
unittests 54.22% <ø> (-2.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotak jotak requested a review from memodi January 9, 2024 12:58
@memodi
Copy link
Contributor

memodi commented Jan 9, 2024

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 9, 2024
Copy link

github-actions bot commented Jan 9, 2024

New image:
quay.io/netobserv/network-observability-console-plugin:3f16709

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=3f16709 make set-plugin-image

@memodi
Copy link
Contributor

memodi commented Jan 9, 2024

@jotak - I tried with the PR image, I still see the same exception. Let me know if you need cluster info.

@jotak
Copy link
Member Author

jotak commented Jan 9, 2024

@memodi did you clear the browser cache?

@memodi
Copy link
Contributor

memodi commented Jan 9, 2024

@memodi did you clear the browser cache?

yes, it was a fresh load when I tried last and now also tried empty cache and hard reload multiple times, on every refresh I am seeing this error.

@jotak
Copy link
Member Author

jotak commented Jan 10, 2024

@memodi indeed I also still see the exception in the javascript console, however it seems like the page is now loading fine despite this error:
image
Isn't it the same for you?

I suspect the remaining error might be something wrong not on netobserv but on the console itself, or on patternfly.

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, let's just ensure it works on all OCP versions

Copy link

openshift-ci bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@memodi
Copy link
Contributor

memodi commented Jan 25, 2024

@jotak - last time when I had tested the error was still thrown, I know you were discussing this with console team - has something changed since then to make error not occur?

@openshift-merge-bot openshift-merge-bot bot merged commit 83a21e0 into netobserv:main Jan 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants