NETOBSERV-1429 Netflow tab crash followup #454
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
==========================================
- Coverage 58.61% 58.55% -0.06%
==========================================
Files 167 167
Lines 8312 8310 -2
Branches 1061 1061
==========================================
- Hits 4872 4866 -6
- Misses 3132 3135 +3
- Partials 308 309 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| if (this.props.children) { | ||
| return this.props.children; | ||
| } | ||
| // else render default NetworkTraffic | ||
|
|
||
| return ( | ||
| <DynamicLoader> | ||
| <AlertFetcher> | ||
| <NetflowTraffic forcedFilters={null} /> | ||
| <NetflowTraffic | ||
| isTab={this.props.isTab} | ||
| forcedFilters={this.props.isTab ? this.props.forcedFilters : null} | ||
| parentConfig={this.props.parentConfig} | ||
| /> | ||
| </AlertFetcher> | ||
| </DynamicLoader> | ||
| ); |
There was a problem hiding this comment.
The magic happens here since I'm forcing NetflowTrafficParent to always load DynamicLoader & AlertFetcher.
Previously these were missing since NetflowTrafficTab was calling
<NetflowTrafficParent>
<NetflowTraffic forcedFilters={forcedFilters} isTab parentConfig={config} />
</NetflowTrafficParent>
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=3a418b6 make set-plugin-image |
There was a problem hiding this comment.
thanks @jpinsonneau
I don't see crash with this PR and test passes.
|
/label qe-approved |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR is a followup of #439 to fix tab crash when loading from direct url / cypress.
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.