NETOBSERV-1355 autocomplete menu button #459
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
- Coverage 58.61% 58.51% -0.10%
==========================================
Files 167 167
Lines 8312 8312
Branches 1061 1061
==========================================
- Hits 4872 4864 -8
- Misses 3132 3140 +8
Partials 308 308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -251,16 +250,16 @@ export const getFilterDefinitions = ( | |||
| | undefined = undefined; | |||
|
|
|||
| if (d.id.includes('namespace')) { | |||
| getOptions = cap10(getNamespaceOptions); | |||
| getOptions = getNamespaceOptions; | |||
There was a problem hiding this comment.
is cap10 replaced by something equivalent somewhere else? I couldn't find that
How does it behave with an extremely long list of items?
There was a problem hiding this comment.
In the video recording above, you can see when I select namespace a scrollbar on the right when the input field is cleared
jotak
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=70ad27d make set-plugin-image |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @jotak ! |
|
/lgtm |
Description
Add a button next to
autocompletesto open / close suggestions.Also added a scroller when options are more than 8.
Screencast.from.2024-01-23.11-17-14.webm
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.