NETOBSERV-1475 zoom-in button on topology view is unclickable in collapse mode

[jpinsonneau]

Description

This is a temporary fix to manage scope slider positionning.
Currently, the slider can cover other components and mess up with zoom buttons.
In this patch, the scope slider only display when possible and adapt it size and position.

I would suggest to backport this to 1.5 if that works for everyone.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[memodi]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:8f46556

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=8f46556 make set-plugin-image

[codecov]

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (c70d29b) 57.42% compared to head (7cb92c6) 58.98%.

❗ Current head 7cb92c6 differs from pull request most recent head f671ba3. Consider uploading reports for the commit f671ba3 to get more accurate results

Files	Patch %	Lines
...c/components/netflow-topology/netflow-topology.tsx	47.61%	10 Missing and 1 partial ⚠️
web/src/components/scope-slider/scope-slider.tsx	20.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
+ Coverage   57.42%   58.98%   +1.55%     
==========================================
  Files         167      137      -30     
  Lines        8670     6298    -2372     
  Branches     1116     1089      -27     
==========================================
- Hits         4979     3715    -1264     
+ Misses       3371     2394     -977     
+ Partials      320      189     -131     

Flag	Coverage Δ
uitests	58.98% <42.30%> (+0.68%)	⬆️
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[memodi]

/label qe-approved

regression tests passes now.

[jotak]

do you know if this is a regression? It may need to be tested with several versions of ocp, if it was previously passing? (cc @memodi )

[jpinsonneau]

do you know if this is a regression? It may need to be tested with several versions of ocp, if it was previously passing? (cc @memodi )

That's not really a regression. It's because I have increased the hardcoded size of the slider to add Cluster and Zone scopes. Now the size is calculated 🐱

[jotak]

/lgtm

[openshift-ci]

New changes are detected. LGTM label has been removed.

[jpinsonneau]

Rebased and backported

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment