-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1503 Console plugin fields config #476
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #476 +/- ##
=======================================
Coverage 57.44% 57.45%
=======================================
Files 167 167
Lines 8681 8710 +29
Branches 1118 1126 +8
=======================================
+ Hits 4987 5004 +17
- Misses 3374 3382 +8
- Partials 320 324 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pkg/handler/config.go
Outdated
Name string `yaml:"name" json:"name"` | ||
Type string `yaml:"type" json:"type"` | ||
Description string `yaml:"description" json:"description"` | ||
// This flag is for documentation only. Use loki.labels instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps it can be omitted then, in this declaration? To avoid any confusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure 👍
2fbb838
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm!
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=d8d4c27 make set-plugin-image |
/label qe-approved |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Followup on netobserv/network-observability-operator#550:
I decided to keep
loki.labels
instead of reusing fieldslokiLabel
since these are generated only for documentation purpose for now.Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.