Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1503 Console plugin fields config #476

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Feb 12, 2024

Description

Followup on netobserv/network-observability-operator#550:

  • get fields from ConfigMap
  • force types when necessary

I decided to keep loki.labels instead of reusing fields lokiLabel since these are generated only for documentation purpose for now.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: Patch coverage is 59.52381% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 57.45%. Comparing base (f59f82b) to head (2fbb838).
Report is 6 commits behind head on main.

Files Patch % Lines
web/src/utils/columns.ts 48.14% 9 Missing and 5 partials ⚠️
web/src/components/modals/columns-modal.tsx 0.00% 2 Missing ⚠️
web/src/components/modals/export-modal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #476   +/-   ##
=======================================
  Coverage   57.44%   57.45%           
=======================================
  Files         167      167           
  Lines        8681     8710   +29     
  Branches     1118     1126    +8     
=======================================
+ Hits         4987     5004   +17     
- Misses       3374     3382    +8     
- Partials      320      324    +4     
Flag Coverage Δ
uitests 58.29% <54.05%> (-0.04%) ⬇️
unittests 55.03% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Name string `yaml:"name" json:"name"`
Type string `yaml:"type" json:"type"`
Description string `yaml:"description" json:"description"`
// This flag is for documentation only. Use loki.labels instead
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps it can be omitted then, in this declaration? To avoid any confusion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure 👍
2fbb838

jotak
jotak previously approved these changes Feb 19, 2024
Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm!

@openshift-ci openshift-ci bot added the lgtm label Feb 19, 2024
@Amoghrd
Copy link
Contributor

Amoghrd commented Feb 27, 2024

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 27, 2024
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:d8d4c27

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=d8d4c27 make set-plugin-image

@Amoghrd
Copy link
Contributor

Amoghrd commented Feb 27, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Feb 27, 2024
@jotak
Copy link
Member

jotak commented Mar 1, 2024

/lgtm

Copy link

openshift-ci bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 22cae24 into netobserv:main Mar 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants