-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1551: show cross-nodes duplicates in merge mode #489
Conversation
@jotak: This pull request references NETOBSERV-1551 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
@jotak: This pull request references NETOBSERV-1551 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
+ Coverage 57.39% 57.49% +0.09%
==========================================
Files 167 167
Lines 8730 8750 +20
Branches 1128 1131 +3
==========================================
+ Hits 5011 5031 +20
Misses 3397 3397
Partials 322 322
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'm fine merging these flows without asking (or rename show duplicate to merge and enable by default 😸 )
|
ad68f67
to
58267fc
Compare
(rebased) |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=c9257af make set-plugin-image |
Ok I added a commit that merges without asking. It could be misleading to show Node-direction = (ingress or egress) while it refers to interfaces that relate to the other peer; but perhaps I am nitpicking here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in terms of code. Thanks !
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=b67f85f make set-plugin-image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jotak I am seeing the interface directions column have n/a set when there are multiple directions, probably it should list multiple directions just the way interfaces are listed?
Env info:
OCP: 4.16.0-0.nightly-2024-03-13-061822
NetObserv operator: v0.0.0-22a1963
Loki: 0-click-loki
eBPF-agent: main
FLP: main
ConsolePlugin: b67f85f
@memodi I confirm the problem but also having the same problem on main branch (although it's harder to see because there isn't as many merged flows, but scrolling a little bit I can find some) Let me see if I can do a quick fix anyway... |
New changes are detected. LGTM label has been removed. |
@memodi last commit should fix it |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=2dffbd1 make set-plugin-image |
@jotak - I thought the flows with multiple interfaces and directions are the merged ones, no? (most ones that are shown in your screenshot) |
@jotak: This pull request references NETOBSERV-1551 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
True but there's 2 levels of merge: first in the agent (this was done by the previous "deduper-merge" PR already merged) but it cannot merge everything, so a second merge is done here with this PR. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR currently just shows the cross-nodes duplicates.
Following the reproduce steps described in NETOBSERV-1551, I'm now seeing both interfaces:
But they are displayed as distinct flows. So it raises the question: should we reintroduce the "Show duplicates" checkbox, since there are still the cross-nodes duplicates even in merge mode? Or should we merge them post-query without asking? If we do so, what to put in Node Direction? "both" ?
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.