Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1514: drop go1.20 support #497

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Mar 12, 2024

No description provided.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.45%. Comparing base (22cae24) to head (9a61a77).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #497   +/-   ##
=======================================
  Coverage   57.45%   57.45%           
=======================================
  Files         167      167           
  Lines        8710     8710           
  Branches     1126     1126           
=======================================
  Hits         5004     5004           
  Misses       3382     3382           
  Partials      324      324           
Flag Coverage Δ
uitests 58.29% <ø> (ø)
unittests 55.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotak jotak changed the title drop go1.20 support NETOBSERV-1514: drop go1.20 support Mar 12, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 12, 2024

@jotak: This pull request references NETOBSERV-1514 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jotak
Copy link
Member Author

jotak commented Mar 12, 2024

/approve

Copy link

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f9786f4 into netobserv:main Mar 12, 2024
9 checks passed
@jotak jotak deleted the drop-1.20 branch March 21, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants