Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prior config refactoring before adding prometheus config #511

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Prior config refactoring before adding prometheus config #511

merged 1 commit into from
Apr 16, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Apr 9, 2024

Description

  • Merged the different Config structs (from handler.Config, server.Config and loki.Config) in a dedicated config package
  • Add names to table-based tests
  • A few linter fixes (e.g. space after comments)

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jotak
Prior config refactoring before adding prometheus config
01c93b5 
- Merged the different Config structs (from handler.Config,
  server.Config and loki.Config) in a dedicated config package
- Add names to table-based tests
- A few linter fixes (e.g. space after comments)
@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Apr 9, 2024
@jotak jotak requested a review from jpinsonneau April 9, 2024 08:14
@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

New image:
quay.io/netobserv/network-observability-console-plugin:7abbe8f

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=7abbe8f make set-plugin-image

jpinsonneau
jpinsonneau approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in terms of code

@openshift-ci openshift-ci bot added the lgtm label Apr 16, 2024
@jotak
Copy link
Member Author

jotak commented Apr 16, 2024

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d804edb into netobserv:main Apr 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpinsonneau jpinsonneau jpinsonneau approved these changes

Assignees

@jpinsonneau jpinsonneau

Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jotak @jpinsonneau