NETOBSERV-1630 allow not for ip filters

[jpinsonneau]

Description

Allow not for ip filters

https://grafana.com/docs/loki/latest/query/ip/

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 56.65%. Comparing base (d53b334) to head (4466f23).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
- Coverage   56.71%   56.65%   -0.07%     
==========================================
  Files         174      174              
  Lines        8990     9000      +10     
  Branches     1179     1179              
==========================================
  Hits         5099     5099              
- Misses       3528     3535       +7     
- Partials      363      366       +3     

Flag	Coverage Δ
uitests	57.85% <ø> (ø)
unittests	53.22% <25.00%> (-0.23%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
pkg/loki/flow_query.go	64.90% <40.00%> (-1.77%)	⬇️
pkg/model/filters/logql.go	68.35% <0.00%> (-1.78%)	⬇️

[jpinsonneau]

@jotak do you remember any reason why not allowing it ?

[jotak]

perhaps.. laziness ? Honestly no I don't remember

[jpinsonneau]

haha no worries. I was wondering if it was related to a specific case not working but I didn't found any during my tests

[jotak]

code lgtm, not tested

[Amoghrd]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:791e663

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=791e663 make set-plugin-image

[Amoghrd]

/label qe-approved

[jotak]

@jpinsonneau can you open a backport PR? thanks!

[jotak]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment