NETOBSERV-1756 Allow filtering based on TCPFlags values #554
Conversation
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=7e21acf make set-plugin-image |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
- Coverage 56.34% 56.31% -0.03%
==========================================
Files 189 190 +1
Lines 9155 9181 +26
Branches 1186 1191 +5
==========================================
+ Hits 5158 5170 +12
- Misses 3626 3641 +15
+ Partials 371 370 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
github-actions
bot
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=46e1fe5 make set-plugin-image |
github-actions
bot
removed
the
ok-to-test
|
|
|
|
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=65bbf5e make set-plugin-image |
jpinsonneau
changed the title
github-actions
bot
removed
the
ok-to-test
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
github-actions
bot
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=52e04b1 make set-plugin-image |
github-actions
bot
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=2f01b4d make set-plugin-image |
github-actions
bot
removed
the
ok-to-test
| case ColumnsId.tcpflags: { | ||
| let child = emptyText(); | ||
| if (typeof value === 'number' && !isNaN(value)) { | ||
| const serviceClassName = gettcpFlagsServiceClassName(value); |
There was a problem hiding this comment.
If I read correctly, this wouldn't decompose the OR-combination, e.g. we can have 3 that is 1+2 = FIN+SYN
There was a problem hiding this comment.
ebpf agent doesn't generate this combo here is what we expect to see in the flags field today https://github.com/netobserv/netobserv-ebpf-agent/blob/main/bpf/utils.h#L11
but we also can or the flags https://github.com/netobserv/netobserv-ebpf-agent/blob/main/bpf/flows.c#L95, do we need to generate all possible combos ?
There was a problem hiding this comment.
I updated the PR to bring in more combos but not the entire list as there some flags with less interest to decode but if I am wrong and we ended up we need to decode all possible combo I think we can revisit and the missing ones ?
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
|
New changes are detected. LGTM label has been removed. |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=a438e8c make set-plugin-image |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Allow filtering based on TCP flags
Dependencies
netobserv/netobserv-ebpf-agent#367
netobserv/network-observability-operator#710
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.