Make it more visible that dashboards are only for openshift

pkg/cluster/cluster.go

@@ -44,8 +44,7 @@ func NewInfo(dcl *discovery.DiscoveryClient) (Info, error) {
 }
 
 func (c *Info) CheckClusterInfo(ctx context.Context, cl client.Client) error {
-	if c.HasOCPSecurity() && !c.fetchedClusterVersion {
-		// Assumes having openshift security <=> being on openshift
+	if c.IsOpenShift() && !c.fetchedClusterVersion {
 		if err := c.fetchOpenShiftClusterVersion(ctx, cl); err != nil {
 			return err
 		}
@@ -114,6 +113,11 @@ func (c *Info) OpenShiftVersionIsAtLeast(v string) (bool, error) {
 	return !c.openShiftVersion.LessThan(*version), nil
 }
 
+// IsOpenShift assumes having openshift SCC API <=> being on openshift
+func (c *Info) IsOpenShift() bool {
+	return c.HasOCPSecurity()
+}
+
 // HasOCPSecurity returns true if "securitycontextconstraints.security.openshift.io" API was found
 func (c *Info) HasOCPSecurity() bool {
 	return c.apisMap[ocpSecurity]

pkg/cluster/dashboards_list.go

@@ -28,10 +28,12 @@ func NewDashboards() Dashboards {
 	}
 }
 
+// CheckClusterDashboards sets the available dashboards based on OpenShift version.
+// This function shouldn't be called in non-OpenShift context.
 func (d *Dashboards) CheckClusterDashboards(ctx context.Context, clusterInfo *Info) {
 	if ok, err := clusterInfo.OpenShiftVersionIsAtLeast("4.15.0"); err != nil {
 		// Log error but do not fail: it's likely a bug in code, if the openshift version cannot be found
-		log.FromContext(ctx).Error(err, "Could not get available dashboards for this cluster version. Is it OpenShift?")
+		log.FromContext(ctx).Error(err, "Could not get available dashboards for this cluster version.")
 	} else if ok {
 		d.SetAvailable(constants.IngressDashboardCMName)
 		d.SetAvailable(constants.NetStatsDashboardCMName)