addressed feedback

apis/flowcollector/v1beta2/flowcollector_types.go

@@ -416,8 +416,10 @@ type FlowCollectorOpenTelemetry struct {
 	TargetPort int `json:"targetPort"`
 
 	// Protocol of Open Telemetry connection. The available options are `http` and `grpc`.
+	// +unionDiscriminator
+	// +kubebuilder:validation:Enum:="http";"grpc"
 	// +optional
-	Protocol string `json:"protocol"`
+	Protocol string `json:"protocol,omitempty"`
 
 	// Headers to add to messages (optional)
 	// +optional
@@ -427,11 +429,11 @@ type FlowCollectorOpenTelemetry struct {
 	// +optional
 	TLS ClientTLS `json:"tls"`
 
-	// Custom rules to transform flow logs to Opentelemetry-conformant format.
-	// By default the following format will be used: https://github.com/rhobs/observability-data-model/blob/main/network-observability.md#format-proposal
-	// Setting `customRules` will fully override the default rules allowing you to export each field to your naming convention
+	// Custom fields mapping to an OpenTelemetry conformant format.
+	// By default, NetObserv format proposal is used: https://github.com/rhobs/observability-data-model/blob/main/network-observability.md#format-proposal .
+	// As there is currently no accepted otlp standard for L3/4 network logs, you can freely override it with your own.
 	// +optional
-	Rules *[]GenericTransformRule `json:"customRules,omitempty"`
+	FieldsMapping *[]GenericTransformRule `json:"fieldsMapping,omitempty"`
 
 	// Open telemetry configuration for logs.
 	// +optional

bundle/manifests/flows.netobserv.io_flowcollectors.yaml

@@ -5804,11 +5804,11 @@ spec:
                       description: Open telemetry configuration, such as the IP address
                         and port to send enriched logs, metrics and or traces to.
                       properties:
-                        customRules:
+                        fieldsMapping:
                           description: |-
-                            Custom rules to transform flow logs to Opentelemetry-conformant format.
-                            By default the following format will be used: https://github.com/rhobs/observability-data-model/blob/main/network-observability.md#format-proposal
-                            Setting `customRules` will fully override the default rules allowing you to export each field to your naming convention
+                            Custom fields mapping to an OpenTelemetry conformant format.
+                            By default, NetObserv format proposal is used: https://github.com/rhobs/observability-data-model/blob/main/network-observability.md#format-proposal .
+                            As there is currently no accepted otlp standard for L3/4 network logs, you can freely override it with your own.
                           items:
                             properties:
                               input:
@@ -5849,6 +5849,9 @@ spec:
                         protocol:
                           description: Protocol of Open Telemetry connection. The
                             available options are `http` and `grpc`.
+                          enum:
+                          - http
+                          - grpc
                           type: string
                         targetHost:
                           default: ""

config/crd/bases/flows.netobserv.io_flowcollectors.yaml

@@ -5367,11 +5367,11 @@ spec:
                       openTelemetry:
                         description: Open telemetry configuration, such as the IP address and port to send enriched logs, metrics and or traces to.
                         properties:
-                          customRules:
+                          fieldsMapping:
                             description: |-
-                              Custom rules to transform flow logs to Opentelemetry-conformant format.
-                              By default the following format will be used: https://github.com/rhobs/observability-data-model/blob/main/network-observability.md#format-proposal
-                              Setting `customRules` will fully override the default rules allowing you to export each field to your naming convention
+                              Custom fields mapping to an OpenTelemetry conformant format.
+                              By default, NetObserv format proposal is used: https://github.com/rhobs/observability-data-model/blob/main/network-observability.md#format-proposal .
+                              As there is currently no accepted otlp standard for L3/4 network logs, you can freely override it with your own.
                             items:
                               properties:
                                 input:
@@ -5409,6 +5409,9 @@ spec:
                             type: object
                           protocol:
                             description: Protocol of Open Telemetry connection. The available options are `http` and `grpc`.
+                            enum:
+                              - http
+                              - grpc
                             type: string
                           targetHost:
                             default: ""

controllers/flp/flp_pipeline_builder.go

@@ -496,7 +496,7 @@ func (b *PipelineBuilder) createOpenTelemetryStage(name string, spec *flowslates
 	// otel logs config
 	if spec.Logs.Enable != nil && *spec.Logs.Enable {
 		// add transform stage
-		transformStage := fromStage.TransformGeneric(fmt.Sprintf("%s-transform", name), helper.GetOtelTransformConfig(spec.Rules))
+		transformStage := fromStage.TransformGeneric(fmt.Sprintf("%s-transform", name), helper.GetOtelTransformConfig(spec.FieldsMapping))
 		// add encode stage(s)
 		transformStage.EncodeOtelLogs(fmt.Sprintf("%s-logs", name), api.EncodeOtlpLogs{
 			OtlpConnectionInfo: &conn,

docs/FlowCollector.md

@@ -11922,12 +11922,12 @@ Open telemetry configuration, such as the IP address and port to send enriched l
         </td>
         <td>true</td>
       </tr><tr>
-        <td><b><a href="#flowcollectorspecexportersindexopentelemetrycustomrulesindex">customRules</a></b></td>
+        <td><b><a href="#flowcollectorspecexportersindexopentelemetryfieldsmappingindex">fieldsMapping</a></b></td>
         <td>[]object</td>
         <td>
-          Custom rules to transform flow logs to Opentelemetry-conformant format.
-By default the following format will be used: https://github.com/rhobs/observability-data-model/blob/main/network-observability.md#format-proposal
-Setting `customRules` will fully override the default rules allowing you to export each field to your naming convention<br/>
+          Custom fields mapping to an OpenTelemetry conformant format.
+By default, NetObserv format proposal is used: https://github.com/rhobs/observability-data-model/blob/main/network-observability.md#format-proposal .
+As there is currently no accepted otlp standard for L3/4 network logs, you can freely override it with your own.<br/>
         </td>
         <td>false</td>
       </tr><tr>
@@ -11953,9 +11953,11 @@ Setting `customRules` will fully override the default rules allowing you to expo
         <td>false</td>
       </tr><tr>
         <td><b>protocol</b></td>
-        <td>string</td>
+        <td>enum</td>
         <td>
           Protocol of Open Telemetry connection. The available options are `http` and `grpc`.<br/>
+          <br/>
+            <i>Enum</i>: http, grpc<br/>
         </td>
         <td>false</td>
       </tr><tr>
@@ -11969,7 +11971,7 @@ Setting `customRules` will fully override the default rules allowing you to expo
 </table>
 
 
-### FlowCollector.spec.exporters[index].openTelemetry.customRules[index]
+### FlowCollector.spec.exporters[index].openTelemetry.fieldsMapping[index]
 <sup><sup>[↩ Parent](#flowcollectorspecexportersindexopentelemetry)</sup></sup>