NETOBSERV-256: Kafka config #107
Conversation
| kubectl create -f "https://strimzi.io/install/latest?namespace="$(NAMESPACE) -n $(NAMESPACE) | ||
| kubectl create -f "https://raw.githubusercontent.com/netobserv/documents/main/examples/kafka-cluster.yaml" -n $(NAMESPACE) | ||
| kubectl create -f "https://raw.githubusercontent.com/netobserv/documents/main/examples/kafka-topic.yaml" -n $(NAMESPACE) |
There was a problem hiding this comment.
Since we mix both strimzi.io / netobserv/document sources, we should fix the version here instead of using latest
There was a problem hiding this comment.
Strimzi only provide this endpoint for its latest version.
The other option is to track this file in one of our repository, but this file has to be changed depending of the targeted namespace.
Since we only use this for now as quick setup for development and since this file is quite big (13k lines) would you be fine to keep using latest for know? If at one point we experience issues it will still be possible to freeze the version there.
There was a problem hiding this comment.
Well if there is no easy solution let's keep this as is. Thanks
OlivierCazade
force-pushed
the
kafka-multi-config
branch
from
8ed3314
to
9d18741
Compare
.mk/development.mk
Outdated
| kubectl create -f "https://raw.githubusercontent.com/netobserv/documents/main/examples/kafka-topic.yaml" -n $(NAMESPACE) | ||
|
|
||
| .PHONY: undeploy-kafka | ||
| undeploy-kafka: ## Undeploy loki. |
There was a problem hiding this comment.
change comment from Undeploy loki to undeploy-kafka
There was a problem hiding this comment.
Done, thanks!
Kafka for now is not enabled by default, since kafka cluster create many differents pods I did not add deploy-kafka to the deploy-all command. Do you think we should deploy kafka in the deploy-all command? |
| kafka: | ||
| enable: false | ||
| address: "kafka-cluster-kafka-bootstrap" | ||
| topic: "flp-topic" |
There was a problem hiding this comment.
as this CR will define the default values in OLM, I'd use a topic name that better describes what it is for. Maybe "netflows" ?
There was a problem hiding this comment.
Actually, network-flows would be better
There was a problem hiding this comment.
Done, thanks!
I think we can continue to keep it turned off by default, at least for the moment |
|
Looks good at first sight 😍
|
|
LGTM (code review + tested), except we should rename the default topic. @OlivierCazade also, the doc should be updated: in README and in the clusterserviceversion file. You can create another story for doc if you prefer. |
New story created: |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: OlivierCazade The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In this PR:
What you need to do to deploy NOO with Kafka: