Remove decode stages, rename some stages #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Following netobserv/flowlogs-pipeline#225 , decode stages should not be set after ingesting ipfix or grpc Also rename stages to make them more explicit
|
btw @memodi I'd be curious to know if there's a noticeable perf improvement with this PR (potentially on flow processing rate or FLP CPU usage) |
|
@jotak ack. We do have some numbers now with 0.1.2 release which will be good for comparison purposes for upcoming release with this change. |
KalmanMeth
pushed a commit
to KalmanMeth/network-observability-operator
that referenced
this pull request
Feb 13, 2023
move health.NewHealthServer before mainPipeline.Run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires netobserv/flowlogs-pipeline#225
Decode stages should not be set after ingesting ipfix or grpc