Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-258: configure eBPF agent for Kafka #121

Merged
merged 2 commits into from
Jun 20, 2022
Merged

NETOBSERV-258: configure eBPF agent for Kafka #121

merged 2 commits into from
Jun 20, 2022

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Jun 16, 2022 •
edited

This PR requires that the following PR is first merged: netobserv/netobserv-ebpf-agent#33

When Kafka and the eBPF agent are set:

  • It deploys the eBPF agent configured to export directly to kafka
  • It does not deploy the flowlogs-processor-ingester daemonset.

@jpinsonneau
Copy link
Contributor

@mariomac I'm not sure if I'm doing something wrong, but I get the following error in ebpf-agent

time="2022-06-20T09:21:27Z" level=info msg="starting NetObserv eBPF Agent"
time="2022-06-20T09:21:27Z" level=fatal msg="can't load configuration from environment" error="env: environment variable \"FLOWS_TARGET_HOST\" should not be empty"

Am I missing something ?

@mariomac
Copy link
Contributor Author

mariomac commented Jun 20, 2022 •
edited

@jpinsonneau might it be that you are using the main netobserv image of the eBPF agent? If yes, you need to build and push your own image from this PR netobserv/netobserv-ebpf-agent#33, then replace it in the flow collector descriptor.

But probably it's just better to wait for the linked PR to be merged.

jpinsonneau
jpinsonneau approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested with netobserv/netobserv-ebpf-agent#33
Good job @mariomac

@openshift-ci openshift-ci bot added the lgtm label Jun 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Jun 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 20, 2022

New changes are detected. LGTM label has been removed.

@mariomac mariomac merged commit 960766c into netobserv:main Jun 20, 2022
@mariomac mariomac deleted the kafka branch June 20, 2022 14:24
KalmanMeth added a commit to KalmanMeth/network-observability-operator that referenced this pull request Feb 13, 2023
@KalmanMeth
updated README to include new config structure (netobserv#121)
054d2ae 
* updated README to include new config structure

* addressed review comments

* updated README to remove reference to environment variables

* showed example combining config file and command-line parameter

* removed reference to .flowlogs-pipeline.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpinsonneau jpinsonneau jpinsonneau approved these changes

@OlivierCazade OlivierCazade Awaiting requested review from OlivierCazade

Assignees

@jpinsonneau jpinsonneau

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mariomac @jpinsonneau