NETOBSERV-182 Drop unused fields #141
Conversation
When using IPFIX, it's now possible to avoid storing lots of garbage by turning dropUnusedFields to true (it actually defaults to true)
|
|
||
| //+kubebuilder:default:=true | ||
| // Set true to drop fields that are known to be unused by OVS, in order to save storage space. | ||
| DropUnusedFields bool `json:"dropUnusedFields,omitempty"` |
There was a problem hiding this comment.
@mariomac I'm adding this field in FLP section as this is where it has an impact, however following the discussion on API review, maybe it makes more sense to have it under "ipfix"? (because it only has effect with ipfix, it would be ignored when agent is ebpf
There was a problem hiding this comment.
Ok, when this PR is merged, I'll rebase my branch and incorporate these changes
There was a problem hiding this comment.
Thinking it twice, I think this field could still be in the FLP section, as:
- It's a configuration for FLP
- Despite it's useless in EBPF, it could still have generic functionality if in the future we use other technologies/agents.
| @@ -127,6 +128,13 @@ func (b *builder) daemonSet(configDigest string) *appsv1.DaemonSet { | |||
| } | |||
| } | |||
|
|
|||
| func (b *builder) portProtocol() corev1.Protocol { | |||
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: ["quay.io/netobserv/network-observability-operator:64090ca"]. It will expire after two weeks. |
|
Some quick measurements (on the left before 19:09, it's using current
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
add animated gif
When using IPFIX, it's now possible to avoid storing lots of garbage by
turning dropUnusedFields to true (it actually defaults to true)
I saw about 30% less space used with this method, uncompressed (it's probably less with compression)