NETOBSERV-505 NOO fails to build with go1.18 and above #146
Conversation
Use 'go install' to install the executable. Note that it still calls 'go get' to update dependencies in go.mod. This stopped working in go1.18 because of https://go.dev/doc/go-get-install-deprecation. In making this change, kustomize broke and no longer installed. The problem is documented in kubernetes-sigs/kustomize#3618. The solution is to use at least v4.5.2. kustomize was upgraded to 4.5.7 from 3.8.8 and everything still worked.
|
+1 but we need to make sure this major upgrade of kustomize doesn't have any wrong side effect on building bundle |
I tested the other make targets that used kustomize, and it seems fine. However, I dd not see the failure that prow reported on controller-gen where it "cannot query module due to -mod=vendor". May have broken backwards-compatibility. |
There is also no need to update dependencies since it is installing a specific version of an executable.
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add recent_op_value and recent_count * Update Counter's source * Add integration test between extractor and prom encoder * rename fields * Update a comment * Update network_definitions * Address Eran's comment: Panic in initValue() on unknown operation * Address Eran's comment: add prefix "total" to count and value * Address Eran's comment: change struct member to be unexported * Address Eran's comment: rename and move common test func to test/utils
Use 'go install' to install the executable. This stopped working in
go1.18 because of https://go.dev/doc/go-get-install-deprecation.
In making this change, kustomize broke and no longer installed. The problem
is documented in kubernetes-sigs/kustomize#3618.
The solution is to use at least v4.5.2. kustomize was upgraded to 4.5.7
from 3.8.8 and everything still worked.