NETOBSERV-435 - Set default req/limits resources for eBPF agent #155
Conversation
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: ["quay.io/netobserv/network-observability-operator:91a62cb"]. It will expire after two weeks. |
| default: | ||
| limits: | ||
| memory: 100Mi | ||
| requests: | ||
| cpu: 100m | ||
| memory: 50Mi |
There was a problem hiding this comment.
I think these defaults for memory would be too low for eBPF. It might be okay for RSS but I have seen container_working_set_bytes for ebpf pods in the order of around 250-300 Mb. It gets OOMKilled when container_working_set_bytes reaches limits.
There was a problem hiding this comment.
I guess we can raise that a bit but as said in the scrum today I think we should keep these values as low as possible upstream since we don't know the cluster size.
We need to add documentation to explain expected values per components per expected amount of flows so the user will be able to override this wisely.
|
Verified, works as expected! |
|
/qe-approved |
github-actions
bot
removed
the
ok-to-test
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ction CI: add continue-on-error: true to commmit stage
I set some minimalist resources spec for eBPF agent as already defined for others components.
This works fine on my dev cluster generating some spam on a httpd deployment:
Another discussion around what limits should be set for downstream is available in NETOBSERV-380
Requests / limits per cluster size should be documented for upstream in NETOBSERV-493