NETOBSERV-448: Moving agent type, ipfix and ebpf config into their own common subsection. #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n common subsection
mariomac
added
ok-to-test
mariomac
requested review from
jotak and
OlivierCazade
and removed request for
jotak
|
New image: ["quay.io/netobserv/network-observability-operator:09fb49d"]. It will expire after two weeks. |
github-actions
bot
removed
the
ok-to-test
OlivierCazade
approved these changes
Sep 6, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing this API review comment: openshift/api#1218 (comment)
This PR introduces the following breaking changes:
agentproperty now is an object. The previousagentstring value now is a property namedtype, inside theagentsection.agent.typevalues now must be uppercase:IPFIXorEBPFipfixandebpfobject sections now are subsections ofagentsection