NETOBSERV-578: allow passing env vars to FLP #180
Conversation
mariomac
added
the
ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New image: ["quay.io/netobserv/network-observability-operator:5b6e4c6"]. It will expire after two weeks. |
| // env allows passing custom environment variables to the Flowlogs-Pipeline pod. | ||
| // This field is useful for passing some concrete performance-tuning options | ||
| // (e.g. GOGC, GOMAXPROCS) that shouldn't be | ||
| // publicly exposed as part of the FlowCollector descriptor. | ||
| //+optional | ||
| Env map[string]string `json:"env,omitempty"` |
There was a problem hiding this comment.
As long as it's there, it's publicly exposed. I'm not 100% sure what we can do here ; e.g. in terms of support, if people start to put any env variable, how does it work, should we still support it? We should consider that first.
Forwarding environment variables to FLP will allow tuning some performance parameters from e.g. the Go runtime.
Here is an example of trading with CPU/Memory by setting
GOGC=400vsGOGC=200vsGOGC=100(default value, unset):