Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-660: Create metric section #181

Merged

Conversation

OlivierCazade
Copy link
Contributor

As an anticipation to more work regarding metrics in FLP and before going GA, create sub metric section in processor section.

@OlivierCazade OlivierCazade changed the title Create metric section NETOBSERV-660: Create metric section Oct 18, 2022
@OlivierCazade
Copy link
Contributor Author

/retest

@jotak
Copy link
Member

jotak commented Oct 18, 2022

/hold
let see with @memodi if we want it in 0.1.5

@memodi
Copy link
Contributor

memodi commented Oct 18, 2022

/hold let see with @memodi if we want it in 0.1.5

thanks @jotak, seems straightforward change, should be fine adding it in if its already reviewed and good to be approved.

@memodi
Copy link
Contributor

memodi commented Oct 18, 2022

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 18, 2022
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-operator:fe7b7aa"]. It will expire after two weeks.

@jotak
Copy link
Member

jotak commented Oct 18, 2022

/unhold

@memodi
Copy link
Contributor

memodi commented Oct 18, 2022

/qe-approved
tested pre-merge.

@jotak jotak added the breaking-change This pull request has breaking changes. They should be described in PR description. label Oct 19, 2022
@jotak
Copy link
Member

jotak commented Oct 19, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 653f243 into netobserv:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved breaking-change This pull request has breaking changes. They should be described in PR description. lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants