NETOBSERV-690 (spike): move eBPF image pullspec from CRD to CSV #190
Conversation
mariomac
changed the title
| @@ -280,6 +275,7 @@ spec: | |||
| set up for the plugin Deployment. | |||
| properties: | |||
| maxReplicas: | |||
| default: 3 | |||
There was a problem hiding this comment.
🤔 are these changes related to your environment ?
I see FlowCollectorHPA.MaxReplicas defined using:
MaxReplicas int32 `json:"maxReplicas" protobuf:"varint,3,opt,name=maxReplicas"`instead of using annotations like:
//+kubebuilder:validation:Minimum=0
//+kubebuilder:default:=3We should create a followup to harmonize these if it's the case
There was a problem hiding this comment.
This isn't related to my changes. But the generated flowcollectors manifest was outdated so when I regenerated mine, the old changes took effect.
Maybe we should add a test target that verifies that the manifests are always up to date.
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
simplify elegant shutdown
From "Best Practices" document:
As an initial test, I'm moving first only one image to evaluate how will it work with CPaaS. Once we succeed, we will move the rest of images.