-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-690 (spike): move eBPF image pullspec from CRD to CSV #190
Conversation
@@ -280,6 +275,7 @@ spec: | |||
set up for the plugin Deployment. | |||
properties: | |||
maxReplicas: | |||
default: 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 are these changes related to your environment ?
I see FlowCollectorHPA.MaxReplicas defined using:
MaxReplicas int32 `json:"maxReplicas" protobuf:"varint,3,opt,name=maxReplicas"`
instead of using annotations like:
//+kubebuilder:validation:Minimum=0
//+kubebuilder:default:=3
We should create a followup to harmonize these if it's the case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't related to my changes. But the generated flowcollectors manifest was outdated so when I regenerated mine, the old changes took effect.
Maybe we should add a test target that verifies that the manifests are always up to date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in terms of code. Thanks @mariomac !
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
simplify elegant shutdown
From "Best Practices" document:
As an initial test, I'm moving first only one image to evaluate how will it work with CPaaS. Once we succeed, we will move the rest of images.