Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-638: avoid infinite update-retrigger loop #193

Merged
merged 3 commits into from
Nov 10, 2022
Merged

NETOBSERV-638: avoid infinite update-retrigger loop #193

merged 3 commits into from
Nov 10, 2022

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Nov 9, 2022

This fixes the idempotency of the agent and FLP generation when the env sections were defined. It also fixes the comparison of some other resources that were unnecessarily reconciliated continuously.

This PR also reverts PR #191 (NETOBSERV-694), as we realized that the error messages were mostly caused by the bug fixed in this PR.

@openshift-ci
Copy link

openshift-ci bot commented Nov 9, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mariomac by writing /assign @mariomac in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link

openshift-ci bot commented Nov 9, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mariomac by writing /assign @mariomac in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mariomac mariomac added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 9, 2022
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

New image: ["quay.io/netobserv/network-observability-operator:c07ebd6"]. It will expire after two weeks.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 10, 2022
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch @mariomac !

@openshift-ci openshift-ci bot added the lgtm label Nov 10, 2022
@mariomac mariomac merged commit 8ba558d into netobserv:main Nov 10, 2022
@mariomac mariomac deleted the fix-loop branch November 10, 2022 21:08
KalmanMeth added a commit to KalmanMeth/network-observability-operator that referenced this pull request Feb 13, 2023
* added topk functionality to aggregate

* tracked index of minimum value

* added unit test for topk

* performed topk on total_value instead of recent_count

* implemented a heap to compute topk

* added mutex to enum to avoid race condition

* pre-populated the enum cache

* checked actual values produced by topk in unit test

* added check to optimize accesses to heap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants