Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend image patching instructions #198

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Amend image patching instructions #198

merged 2 commits into from
Nov 25, 2022

Conversation

mariomac
Copy link
Contributor

oc set env or kubectl set env is a much more convenient tool for changing the related images.

@mariomac mariomac requested a review from jotak November 22, 2022 11:37
Copy link
Contributor

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jotak
Copy link
Member

jotak commented Nov 25, 2022

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Nov 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mariomac mariomac merged commit eb29ee5 into netobserv:main Nov 25, 2022
@mariomac mariomac deleted the patch branch November 25, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants