Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make script to update images #201

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

jotak
Copy link
Member

@jotak jotak commented Nov 25, 2022

No description provided.

@jotak jotak requested a review from mariomac November 25, 2022 10:28
@jotak
Copy link
Member Author

jotak commented Nov 25, 2022

Example of usage:

USER=me VERSION=test make set-flp-image

Or without even "USER" if your shell username matches your quay account

Copy link
Contributor

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jotak
Copy link
Member Author

jotak commented Nov 25, 2022

/hold

@mariomac we can merge your PR first, then I'll update the doc (and add the -c manager) in mine

@mariomac
Copy link
Contributor

@jotak ok. It's merged just now

@jotak
Copy link
Member Author

jotak commented Nov 25, 2022

/unhold
ready

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@jotak
Copy link
Member Author

jotak commented Nov 25, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 51ed266 into netobserv:main Nov 25, 2022
@jotak jotak deleted the make-set-env branch December 2, 2022 13:04
KalmanMeth pushed a commit to KalmanMeth/network-observability-operator that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants