Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix make run (ocp and local) #203

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

eranra
Copy link
Contributor

@eranra eranra commented Nov 27, 2022

  • Fix the sample by pinning it to a specific version (4.1)
  • Adding required parameters to run operator command (from the command line)

@jotak
Copy link
Member

jotak commented Nov 30, 2022

/lgtm
thanks!

@jotak
Copy link
Member

jotak commented Nov 30, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 000070b into netobserv:main Nov 30, 2022
KalmanMeth pushed a commit to KalmanMeth/network-observability-operator that referenced this pull request Feb 13, 2023
[breaking change] Fix protobuf decode for new time fields in ms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants