NETOBSERV-655: created debug section and moved imagepullpolicy and env #207
Conversation
mariomac
added
the
breaking-change
api/v1alpha1/flowcollector_types.go
Outdated
| //+kubebuilder:validation:Enum=IfNotPresent;Always;Never | ||
| //+kubebuilder:default:=IfNotPresent | ||
| // imagePullPolicy is the Kubernetes pull policy for the component image. | ||
| ImagePullPolicy string `json:"imagePullPolicy,omitempty"` |
There was a problem hiding this comment.
I would not put pull policies under "debug" : some people prefer always pulling and others not, it's a legitimate option not just for debugging
There was a problem hiding this comment.
Ok. I moved it here because it looked a bit strange that the images are not here anymore but the ImagePullPolicy is actually here.
Also because I was thinking on, after GA, we could restore the "image" fields under the debug section so they would override the CSV relatedImages entry if they were defined here. So we wouldn't need to patch the CSV or deployment during development.
|
thanks! |
|
so this is to be backported |
|
@jotak yes, creating the backport once we merge this |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* NETOBSERV-655: created debug section and moved imagepullpolicy and env (#207) * NETOBSERV-655: created debug section and moved imagepullpolicy and env * Update generation * Addressed jotak's comments * update operator-sdk
NETOBSERV-341 configure netflow v5 separately (breaking change if using v5)
No description provided.