NETOBSERV-672: Document bug when flowcollector is deployed before kafka #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariomac
reviewed
Dec 1, 2022
README.md
Outdated
| @@ -237,6 +237,10 @@ kubectl get pods -n netobserv -l app=netobserv-plugin | |||
| kubectl logs -n netobserv -l app=netobserv-plugin | |||
| ``` | |||
|
|
|||
| ### I first deployed flowcollector, and then kafka. Flowlogs-pipeline is not consuming any flow from Kafka | |||
|
|
|||
| This is a known bug in one of flowlogs-pipeline dependencies. Please recreate the flowlogs-pipeline pods by killing them, they will be automatically recreated. | |||
There was a problem hiding this comment.
Maybe add the link to the issue in the kafka lib, if it exists. I'd maybe suggest, as another alternative, to redeploy the flow collector, in addition to killing pods one by one.
mariomac
approved these changes
Dec 7, 2022
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: OlivierCazade The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
KalmanMeth
pushed a commit
to KalmanMeth/network-observability-operator
that referenced
this pull request
Feb 13, 2023
* Add basic functionality of connection tracking * Minor fixes * Add ConnTrackOutputRecordTypeEnum * Add ConnTrackOperationName enum * Add test case for aggregator of type sum * Add flow logs to warning message * Rename buildConnTrackConfig() -> buildMockConnTrackConfig() * Rename a variable h -> hash * Rename NewFlowLog() -> newMockFlowLog() and move to utils_tests.go * Strip "aggregate" from aggregators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested and confirmed that the bug come from the kafka-go dependency.
I am trying to fix it and I opened a bug report in the library side.
Meanwhile for GA, I think it is better to document the workaround.