CRD doc update - simplified sample #224
Conversation
jotak
commented
Dec 13, 2022
jotak
commented
- add some explanation about agent's privileged mode
- add some hints when configuring kafka & TLS
- add some hints about mTLS
- remove IPFIX from the sample CR (it still exists but wouldn't show up as the sample CR when installing from OLM console)
- remove a couple of other much unused fields from the sample CR
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This is to be backported to 4.12 |
| // privileged mode for the eBPF Agent container. If false, the operator will add the following | ||
| // capabilities to the container, to enable its correct operation: | ||
| // BPF, PERFMON, NET_ADMIN, SYS_RESOURCE. | ||
| // privileged mode for the eBPF Agent container. In general this setting can be ignored or set to false: |
There was a problem hiding this comment.
@mariomac can you take a look at this description in particular?
There was a problem hiding this comment.
Much clearer, thanks for adding context to this!
- add some explanation about agent's privileged mode - add some hints when configuring kafka & TLS - add some hints about mTLS - remove IPFIX from the sample CR (it still exists but wouldn't show up as the sample CR when installing from OLM console) - remove a couple of other much unused fields from the sample CR
jotak
force-pushed
the
crd-doc-update
branch
from
139291a
to
8282cb6
Compare
| @@ -7,7 +7,7 @@ LABEL operators.operatorframework.io.bundle.metadata.v1=metadata/ | |||
| LABEL operators.operatorframework.io.bundle.package.v1=netobserv-operator | |||
| LABEL operators.operatorframework.io.bundle.channels.v1=v0.2.x | |||
| LABEL operators.operatorframework.io.bundle.channel.default.v1=v0.2.x | |||
| LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.25.2 | |||
| LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.25.3 | |||
There was a problem hiding this comment.
Makefile is still downloading v1.25.2. Maybe you'd need to update also the downloaded version in the makefile
| ovnKubernetes: | ||
| namespace: ovn-kubernetes | ||
| daemonSetName: ovnkube-node | ||
| containerName: ovnkube-node |
There was a problem hiding this comment.
I thought this file was automatically generated but it seems not. Good to know!
There was a problem hiding this comment.
Yes, in general I want to have all exposed config in this file so it also serves as a reference, however for stuff that are deprecated or that for some reason we don't want to advertise on, it's probably better to not have them here
|
New changes are detected. LGTM label has been removed. |
* CRD doc update - simplified sample - add some explanation about agent's privileged mode - add some hints when configuring kafka & TLS - add some hints about mTLS - remove IPFIX from the sample CR (it still exists but wouldn't show up as the sample CR when installing from OLM console) - remove a couple of other much unused fields from the sample CR * update operator-sdk default version
* CRD doc update - simplified sample - add some explanation about agent's privileged mode - add some hints when configuring kafka & TLS - add some hints about mTLS - remove IPFIX from the sample CR (it still exists but wouldn't show up as the sample CR when installing from OLM console) - remove a couple of other much unused fields from the sample CR * update operator-sdk default version
