Update golangci-lint #227
Update golangci-lint #227
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| - errcheck | ||
| - errorlint | ||
| - cyclop | ||
| - errname | ||
| - exhaustive | ||
| - exportloopref | ||
| - gocritic | ||
| - goimports | ||
| - gofmt |
There was a problem hiding this comment.
goimports complains with the generated sources. Will see if we can revert this change in a later version.
| @@ -1,27 +1,24 @@ | |||
| linters: | |||
| enable: | |||
| - deadcode | |||
There was a problem hiding this comment.
deadcode, structcheck and varcheck linters are warned as removed by the linter, so I removed them from here.
|
@mariomac: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Merged without passing tests because there is a deadlock: Prow needs to be updated to Go 1.18 but can't be updated if we don't fix linting here. |
We can't update prow to 1.18 because golangci-lint is in an old version and can't recognize the newer format of some modules:
openshift/release#34809
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/34809/rehearse-34809-pull-ci-netobserv-goflow2-kube-enricher-main-lint/1603049581493358592
We need first to update golangci-lint here and in release-4.12 to unlock the situation