Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-757 github actions maintenance + add CI test to replace prow #230

Merged
merged 2 commits into from
Jan 20, 2023
Merged

NETOBSERV-757 github actions maintenance + add CI test to replace prow #230

merged 2 commits into from
Jan 20, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Dec 15, 2022

Hold until GA?

@openshift-ci
Copy link

openshift-ci bot commented Dec 15, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jotak jotak marked this pull request as ready for review January 20, 2023 13:18
@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 20, 2023
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-operator:0639543"]. It will expire after two weeks.

@openshift-ci openshift-ci bot added the lgtm label Jan 20, 2023
@jotak
Copy link
Member Author

jotak commented Jan 20, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d6b6a92 into netobserv:main Jan 20, 2023
KalmanMeth pushed a commit to KalmanMeth/network-observability-operator that referenced this pull request Feb 13, 2023
@ronensc
Conntrack: Add RecordType and HashId fields (netobserv#230)
b74bf07 
* Add hash id to records

* Add type field

* Add a common internal prefix to field names

* Change prefix of internal fields to underscore "_"
@jotak jotak deleted the update-gha branch September 28, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpinsonneau jpinsonneau jpinsonneau approved these changes

@mariomac mariomac Awaiting requested review from mariomac

@OlivierCazade OlivierCazade Awaiting requested review from OlivierCazade

Assignees

@jpinsonneau jpinsonneau

Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jotak @jpinsonneau @openshift-merge-robot