Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention 'cannot be updated' on requests/limits #237

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

jotak
Copy link
Member

@jotak jotak commented Dec 21, 2022

No description provided.

@jotak
Copy link
Member Author

jotak commented Dec 21, 2022

I'll backport it to 4.12 as it has an impact on the generated doc, which is wrong in that regard

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit

@memodi
Copy link
Contributor

memodi commented Dec 21, 2022

I'll backport it to 4.12 as it has an impact on the generated doc, which is wrong in that regard

to understand impact on downstream docs, are those copied/pasted from here upstream?

@memodi
Copy link
Contributor

memodi commented Dec 21, 2022

/qe-approved

@jotak
Copy link
Member Author

jotak commented Dec 21, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Dec 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9480192 into netobserv:main Dec 21, 2022
KalmanMeth pushed a commit to KalmanMeth/network-observability-operator that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants